Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Issue 138 #139

Merged
merged 2 commits into from
Apr 9, 2021
Merged

Fix: Issue 138 #139

merged 2 commits into from
Apr 9, 2021

Conversation

pabamato
Copy link
Contributor

Description of the Change

Set the correct value to site_public if RSA_FORBID_RESTRICTION is defined

Alternate Designs

Benefits

Mimic core behavior

Possible Drawbacks

Verification Process

  • Define RSA_FORBID_RESTRICTION to true in wp-config.php
  • Go to settings>reading and verify the correct option is checked
  • Check robots.txt content is correct and matches the same output as when the constant was not defined

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

#138

@pabamato pabamato requested a review from jeffpaul March 16, 2021 04:13
@jeffpaul jeffpaul added this to the 7.3.0 milestone Mar 16, 2021
@jeffpaul jeffpaul requested a review from dinhtungdu March 16, 2021 04:20
@jeffpaul jeffpaul merged commit e126455 into develop Apr 9, 2021
@jeffpaul jeffpaul deleted the fix/filter-option-asigns-wrong-value branch April 21, 2021 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter option setting the wrong value when RSA_FORBID_RESTRICTION is defined
3 participants