Skip to content
This repository has been archived by the owner on May 2, 2024. It is now read-only.

move saved connections above the search field #30

Merged
merged 1 commit into from
Aug 5, 2020
Merged

move saved connections above the search field #30

merged 1 commit into from
Aug 5, 2020

Conversation

gthayer
Copy link

@gthayer gthayer commented May 12, 2020

Description of the Change

Based on a client's feedback, I've moved the selected posts section above the search field. Version 0.2.0 was setup this way, but in 0.3.0 having the selected posts below the search results pushes the already selected items off screen making if difficult to see what has already been added.

** Current Display**
image

Updated Display
image

Benefits

This will make it easier for editors to see what has already been attached to a post when adding new connections.

Possible Drawbacks

None come to mind

Verification Process

It's a visual update and I can't imagine a reason why we'd want the selected results at the bottom.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

@jeffpaul jeffpaul added this to the 0.4.0 milestone May 13, 2020
Copy link
Member

@nicholasio nicholasio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me and I don't have any concerns with moving the search results.

@jeffpaul Just wondering if this would be considered a minor release since it's going to change the UI? We also need to bump the plugin version accordingly.

@jeffpaul
Copy link
Member

@nicholasio yeah we can bump to 0.3.1 instead if you prefer, noting that the release will also include #27 and #29. Do you want to try and resolve either of the two open issues with this release or will the one open and two merged PRs suffice for your needs?

@jeffpaul
Copy link
Member

@nicholasio @eugene-manuilov do either of you have a preference on merging this and tagging/releasing as 0.3.1 or 0.4.0?

@eugene-manuilov
Copy link
Collaborator

@jeffpaul i think it should be 0.3.1 since it's just a minor change.

@nicholasio
Copy link
Member

Yeah a minor release should be fine.

@jeffpaul jeffpaul merged commit 1ce460c into 10up:master Aug 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants