Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add plugin assets for WP.org #14

Merged
merged 3 commits into from
Oct 29, 2020
Merged

add plugin assets for WP.org #14

merged 3 commits into from
Oct 29, 2020

Conversation

jeffpaul
Copy link
Member

Description of the Change

This PR adds the banner and icon images for display on WordPress.org.

Alternate Designs

n/a

Benefits

Ensures we leverage the image spots for plugin marketing aspects on WordPress.org.

Possible Drawbacks

none identified.

Verification Process

Manually verified via GitHub Desktop UI.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

n/a

Changelog Entry

### Added
- Plugin banner and icon images (props [@dianapadron](https://profiles.wordpress.org/dianapadron))

@jeffpaul jeffpaul added this to the 1.0.1 milestone Oct 26, 2020
@jeffpaul jeffpaul self-assigned this Oct 26, 2020
@jeffpaul jeffpaul requested a review from dsawardekar October 28, 2020 20:08
@jeffpaul
Copy link
Member Author

@dsawardekar I had to update the composer.lock file to clear an issue in my earlier commit (of just plugin assets) so hoping you can validate that things look/work as expected with that composer update I ran?

@dsawardekar
Copy link
Collaborator

@jeffpaul The changes look good. Love the new banner & icons. :)

@jeffpaul jeffpaul merged commit 04adbfa into develop Oct 29, 2020
@jeffpaul jeffpaul modified the milestones: 1.0.1, 1.0.0 Jan 14, 2021
@jeffpaul jeffpaul deleted the add/assets branch February 8, 2021 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants