-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix WP 5.6 array_intersect_key error #263
Conversation
@phpbits Code looks good but I think this will cause some other errors we will need to solve. Currently, we take that route argument and use that later on, to determine which type of processing we are doing. That check expects a string but we are now going to be passing an array, which I think will cause things to break. See here for one place this is done: https://github.com/10up/classifai/blob/develop/includes/Classifai/Providers/Azure/ComputerVision.php#L928 |
This same error was reported today via email:
@dkotter @dinhtungdu if @phpbits approach is not the optimal path, then is there another approach you'd recommend to help resolve this error? |
I think the fix we have here is correct but there's more needed to ensure this doesn't break other things within Classifai. Anywhere in the plugin we use that |
After chatting with @phpbits I'm going to tag in @dinhtungdu to help work on the additional updates from @dkotter. |
@dkotter I updated the PR to address the data type change. |
This PR fixes the error below when using WordPress 5.6. This errors are only visible when on Gutenberg editor.