Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix add missing ? in optional chaining when trying to access media size #271

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

fabiankaegy
Copy link
Member

Description of the Change

Add missing optional chaining step in media details selector

Closes #270

How to test the Change

Changelog Entry

Fixed - Add optional chaining to media details in image component

Credits

Props @johnwatkins0 @fabiankaegy

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@github-actions
Copy link

Size Change: +2 B (0%)

Total Size: 65.2 kB

Filename Size Change
dist/index.js 65.2 kB +2 B (0%)

compressed-size-action

@cypress
Copy link

cypress bot commented Oct 25, 2023

Passing run #675 ↗︎

0 6 0 0 Flakiness 0

Details:

fix add missing ? in optional chaining when trying to access media size
Project: 10up Block Components Commit: 41ff488805
Status: Passed Duration: 03:20 💡
Started: Oct 25, 2023 7:36 AM Ended: Oct 25, 2023 7:39 AM

Review all test suite changes for PR #271 ↗︎

Copy link
Member

@Antonio-Laguna Antonio-Laguna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fabiankaegy fabiankaegy merged commit 83d93ae into develop Oct 25, 2023
@fabiankaegy fabiankaegy deleted the fix/optional-chaining-image-component branch October 25, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Image [Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing optional chaining operator
2 participants