Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature | Improve Icon Picker by virtualizing icon grid and using fuzzy search #243

Merged
merged 10 commits into from
Aug 7, 2023

Conversation

fabiankaegy
Copy link
Member

Description of the Change

Improve the quality of search results in Icon Picker by switching to using a fuzzy search algorithm used inside useFilteredList
Also updates Icon Picker grid of icons to using virtualized rendering of Icons to improve the performance of large icon sets.

Closes #

How to test the Change

Use the Icon Picker Example component from the example blocks

Changelog Entry

Fixed - Search use fuzzy search algorithm used inside useFilteredList to improve quality of search results
Fixed - Use virtualized rendering of Icons in IconPicker Grid to improve the performance of large icon sets

Credits

Props @fabiankaegy

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@github-actions
Copy link

github-actions bot commented Aug 4, 2023

Size Change: +519 B (+1%)

Total Size: 53.5 kB

Filename Size Change
dist/index.js 53.5 kB +519 B (+1%)

compressed-size-action

Copy link
Member

@Antonio-Laguna Antonio-Laguna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM!

uFuzzy looks very useful in this scenario, well thought!

@fabiankaegy fabiankaegy merged commit d70af9a into develop Aug 7, 2023
@fabiankaegy fabiankaegy deleted the feature/improve-icon-picker branch August 7, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants