Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code to use updated ->get_settings() method #3558

Merged
merged 2 commits into from
Jul 27, 2023

Conversation

oscarssanchez
Copy link
Contributor

@oscarssanchez oscarssanchez commented Jul 25, 2023

Description of the Change

Closes #1930

How to test the Change

Adding settings etc should remain the same.

Changelog Entry

Changed - Refactor get_settings() usage inside ElasticPress features.

Credits

Props @oscarssanchez, @felipeelia

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@oscarssanchez oscarssanchez requested a review from felipeelia July 26, 2023 18:02
@oscarssanchez oscarssanchez added this to the 4.7.0 milestone Jul 26, 2023
@felipeelia felipeelia merged commit 7b72dd6 into develop Jul 27, 2023
@felipeelia felipeelia deleted the fix/issue-1930 branch July 27, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Features: default_settings and get_settings()
2 participants