New ep_facet_should_check_if_allowed filter #3430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burhandodhy
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR changes the way Meta fields Facets filter the results. Previously, it would be possible to filter simply by adding a parameter to the URL. Now, it will only filter results using meta fields selected in blocks.
Using
add_filter( 'ep_facet_should_check_if_allowed', '__return_false' );makes EP use the old behavior.How to test the Change
Visit /?ep_meta_filter_= in a field that is not selected in a facet before and after checking out this PR.
Changelog Entry
Credits
Props @felipeelia @burhandodhy
Checklist: