Change disabling method to avoid losing focus on facets #3209
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
When facets are used in Instant Results the facet option checkboxes are disabled during loading to avoid a situation where the user selects two mutually incompatible options. This was being done using the
disabled
attribute, but the problem was that when this attribute was applied the checkboxes lost focus, meaning that keyboard users would lose their position.This PR changes the checkbox to instead use
aria-disabled
for indicating the disabled status and to check the disabled status inside the onChange callback. This still prevents the user selecting mutually incompatible filters, but without losing keyboard focus on the checkbox,Closes #3201
How to test the Change
Changelog Entry
Fixed - An issue where keyboard focus on a facet option was lost upon selection.
Credits
Props @JakePT
Checklist: