Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for WP-CLI Commands #3183

Merged
merged 6 commits into from
Dec 8, 2022
Merged

Add test for WP-CLI Commands #3183

merged 6 commits into from
Dec 8, 2022

Conversation

burhandodhy
Copy link
Contributor

@burhandodhy burhandodhy commented Dec 6, 2022 •
edited
Loading

Description of the Change

This PR adds the Unit Tests for the WP-CLI commands and one test for the Protected Content feature

Closes #3054

How to test the Change

Changelog Entry

Added - Unit Tests for WP-CLI Commands and one test for Protected Feature

Credits

Props @burhandodhy

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@burhandodhy burhandodhy force-pushed the chore/improve-test-coverage-3054 branch from a428102 to eb79044 Compare December 6, 2022 13:14
@burhandodhy burhandodhy changed the title [WIP] Add test for WP-CLI Commands Add test for WP-CLI Commands Dec 6, 2022
@burhandodhy burhandodhy marked this pull request as ready for review December 6, 2022 13:18
@burhandodhy burhandodhy added this to the 4.4.1 milestone Dec 6, 2022
@burhandodhy burhandodhy assigned burhandodhy and unassigned felipeelia Dec 6, 2022
@burhandodhy burhandodhy assigned felipeelia and unassigned burhandodhy Dec 7, 2022
felipeelia
felipeelia requested changes Dec 7, 2022
View reviewed changes
Copy link
Member

@felipeelia felipeelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is just a detail before we merge this one @burhandodhy. Thanks!

tests/php/TestCommands.php Outdated Show resolved Hide resolved
@felipeelia felipeelia assigned burhandodhy and unassigned felipeelia Dec 7, 2022
@burhandodhy burhandodhy assigned felipeelia and unassigned burhandodhy Dec 7, 2022
@burhandodhy burhandodhy force-pushed the chore/improve-test-coverage-3054 branch from 085ad7c to 1d647d5 Compare December 8, 2022 11:00
@felipeelia felipeelia merged commit 2e427d9 into develop Dec 8, 2022
@felipeelia felipeelia deleted the chore/improve-test-coverage-3054 branch December 8, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipeelia felipeelia felipeelia requested changes

Assignees

@felipeelia felipeelia

Labels
None yet
Projects
None yet
Milestone
4.4.1
Development

Successfully merging this pull request may close these issues.

Improve PHP Unit Tests Coverage
2 participants
@burhandodhy @felipeelia