-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Orders autosuggest foundations #3175
Conversation
f8d8d90
to
fa7f004
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JakePT I left some comments (mostly just thoughts and things we will need to keep track of). Do you mind reaching out to me on slack to share an endpoint I can use to test it? Thanks!
|
||
$token = base64_encode( "$response->username:$response->clear_password" ); // phpcs:ignore WordPress.PHP.DiscouragedPHPFunctions.obfuscation_base64_encode | ||
|
||
update_user_meta( $user_id, 'ep_temporary_token', $token ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to delete these during the plugin uninstall. Also, this will eventually expire, right? I didn't find where we are getting a new one if that is the case, sorry :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@felipeelia Yeah I'll check with Dustin how we want to do that. At the moment it's treated as if the tokens are permanent.
Description of the Change
The PR implements the foundations for the orders autosuggest for WooCommerce feature. It includes:
The class is not instantiated in the WooCommerce feature, so it can not be currently activated.
Remaining to be implemented, as per #3277, are:
How to test the Change
( new Orders() )->setup();
to thesetup()
method of the WooCommerce feature class.Changelog Entry
Credits
@JakePT
Checklist: