Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support transforming legacy widgets to blocks and hide widgets when the blocks are available #2819

Merged
merged 22 commits into from
Aug 12, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .wp-env.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
],
"plugins": [
".",
"https://downloads.wordpress.org/plugin/classic-widgets.zip",
"https://downloads.wordpress.org/plugin/debug-bar.zip",
"https://downloads.wordpress.org/plugin/debug-bar-elasticpress.zip",
"https://downloads.wordpress.org/plugin/wordpress-importer.zip",
Expand Down
2 changes: 2 additions & 0 deletions assets/js/blocks/facets/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,11 @@ import { registerBlockType } from '@wordpress/blocks';
* Internal dependencies.
*/
import edit from './edit';
import transforms from './transforms';
import block from './block.json';

registerBlockType(block, {
edit,
save: () => {},
transforms,
});
29 changes: 29 additions & 0 deletions assets/js/blocks/facets/transforms.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
/**
* WordPress dependencies.
*/
import { createBlock } from '@wordpress/blocks';

/**
* Facet widget block transforms.
*/
export default {
from: [
{
type: 'block',
blocks: ['core/legacy-widget'],
isMatch: ({ idBase }) => idBase === 'ep-facet',
transform: ({ instance }) => {
const { title = null, ...attributes } = instance.raw;

if (!title) {
return createBlock('elasticpress/facet', attributes);
}

return [
createBlock('core/heading', { content: title }),
createBlock('elasticpress/facet', attributes),
];
},
},
],
};
2 changes: 2 additions & 0 deletions assets/js/blocks/related-posts/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,10 @@ import { registerBlockType } from '@wordpress/blocks';
*/
import Edit from './Edit';
import block from './block.json';
import transforms from './transforms';

registerBlockType(block, {
edit: (props) => <Edit {...props} />,
save: () => {},
transforms,
});
29 changes: 29 additions & 0 deletions assets/js/blocks/related-posts/transforms.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
/**
* WordPress dependencies.
*/
import { createBlock } from '@wordpress/blocks';

/**
* Facet widget block transforms.
*/
export default {
from: [
{
type: 'block',
blocks: ['core/legacy-widget'],
isMatch: ({ idBase }) => idBase === 'ep-related-posts',
transform: ({ instance }) => {
const { title = null, num_posts: number } = instance.raw;

if (!title) {
return createBlock('elasticpress/related-posts', { number });
}

return [
createBlock('core/heading', { content: title }),
createBlock('elasticpress/related-posts', { number }),
];
},
},
],
};
17 changes: 17 additions & 0 deletions includes/classes/Feature/Facets/Facets.php
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ public function setup() {
}

add_action( 'widgets_init', [ $this, 'register_widgets' ] );
add_filter( 'widget_types_to_hide_from_legacy_widget_block', [ $this, 'hide_legacy_widget' ] );
add_action( 'ep_valid_response', [ $this, 'get_aggs' ], 10, 4 );
add_filter( 'ep_post_formatted_args', [ $this, 'set_agg_filters' ], 10, 3 );
add_action( 'pre_get_posts', [ $this, 'facet_query' ] );
Expand Down Expand Up @@ -488,6 +489,22 @@ public function register_widgets() {
register_widget( __NAMESPACE__ . '\Widget' );
}

/**
* Hide the legacy widget.
*
* Hides the legacy widget in favor of the Block when the block editor
* is in use and the legacy widget has not been used.
*
* @since 4.3
* @param array $widgets An array of excluded widget-type IDs.
* @return array array of excluded widget-type IDs to hide.
*/
public function hide_legacy_widget( $widgets ) {
$widgets[] = 'ep-facet';

return $widgets;
}

/**
* Output feature box long
*
Expand Down
6 changes: 5 additions & 1 deletion includes/classes/Feature/Facets/Widget.php
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,11 @@ class Widget extends WP_Widget {
* Create widget
*/
public function __construct() {
$options = array( 'description' => esc_html__( 'Add a facet to an archive or search results page.', 'elasticpress' ) );
$options = array(
'description' => esc_html__( 'Add a facet to an archive or search results page.', 'elasticpress' ),
'show_instance_in_rest' => true,
);

parent::__construct( 'ep-facet', esc_html__( 'ElasticPress - Facet', 'elasticpress' ), $options );

$this->renderer = new Renderer();
Expand Down
17 changes: 17 additions & 0 deletions includes/classes/Feature/RelatedPosts/RelatedPosts.php
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,7 @@ public function find_related( $post_id, $return = 5 ) {
*/
public function setup() {
add_action( 'widgets_init', [ $this, 'register_widget' ] );
add_filter( 'widget_types_to_hide_from_legacy_widget_block', [ $this, 'hide_legacy_widget' ] );
add_filter( 'ep_formatted_args', [ $this, 'formatted_args' ], 10, 2 );
add_action( 'init', [ $this, 'register_block' ] );
add_action( 'rest_api_init', [ $this, 'setup_endpoint' ] );
Expand Down Expand Up @@ -308,6 +309,22 @@ public function register_widget() {
register_widget( __NAMESPACE__ . '\Widget' );
}

/**
* Hide the legacy widget.
*
* Hides the legacy widget in favor of the Block when the block editor
* is in use and the legacy widget has not been used.
*
* @since 4.3
* @param array $widgets An array of excluded widget-type IDs.
* @return array array of excluded widget-type IDs to hide.
*/
public function hide_legacy_widget( $widgets ) {
$widgets[] = 'ep-related-posts';

return $widgets;
}

/**
* Output feature box long
*
Expand Down
6 changes: 5 additions & 1 deletion includes/classes/Feature/RelatedPosts/Widget.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,11 @@ class Widget extends WP_Widget {
* @since 6.4
*/
public function __construct() {
$options = array( 'description' => esc_html__( 'Show related posts using ElasticPress. This widget will only appear on single post, page, and custom type pages.', 'elasticpress' ) );
$options = array(
'description' => esc_html__( 'Show related posts using ElasticPress. This widget will only appear on single post, page, and custom type pages.', 'elasticpress' ),
'show_instance_in_rest' => true,
);

parent::__construct( 'ep-related-posts', esc_html__( 'ElasticPress - Related Posts', 'elasticpress' ), $options );
}

Expand Down
Loading