Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing text domain in Command.php #2192

Merged
merged 1 commit into from
May 6, 2021
Merged

Add missing text domain in Command.php #2192

merged 1 commit into from
May 6, 2021

Conversation

Rahmon
Copy link
Contributor

@Rahmon Rahmon commented May 3, 2021

Description of the Change

This change adds missing text domains in Command.php introduced by #2120.

Alternate Designs

Benefits

Possible Drawbacks

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Closes: #2191

Changelog Entry

@Rahmon Rahmon requested a review from oscarssanchez May 3, 2021 11:44
@oscarssanchez
Copy link
Contributor

Looks good @Rahmon

@brandwaffle brandwaffle merged commit 8d3845d into develop May 6, 2021
@brandwaffle brandwaffle deleted the fix/missing-text-domaing-issue-2191 branch May 6, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscarssanchez oscarssanchez oscarssanchez approved these changes

Assignees

@oscarssanchez oscarssanchez

Labels
high priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: Lack of text domain in esc_html__() calls
3 participants
@Rahmon @oscarssanchez @brandwaffle