Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exclude from Search checkbox to pages and posts #1877

Closed
wants to merge 6 commits into from

Conversation

amesplant
Copy link
Contributor

Description of the Change

Add Exclude from Search Checkbox in the sidebar

Alternate Designs

None that I am aware of

Benefits

Allows the user to indicate this page should be excluded from the search results

Possible Drawbacks

current version only available in Gutenberg

Verification Process

  • checked that the meta attribute for 'exclude_from_search' was false on initial load wp.data.select('core/editor').getEditedPostAttribute('meta') which returned {exclude_from_search: false}
  • selected 'exclude_from_search', published the post / page and checked to make sure that this time {exclude_from_search: false} was returned.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Changelog Entry

@tlovett1
Copy link
Member

Hey @amesplant I think you or someone else will also need to tie this to the query integration such that posts are actually excluded.

@felipeelia
Copy link
Member

Closing as this feature was introduced in EP 4.4.0 via #3100.

@felipeelia felipeelia closed this Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants