Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #123 : updated Makefile to support windows #128

Merged
merged 4 commits into from
Nov 2, 2021

Conversation

gauravp446
Copy link
Contributor

@gauravp446 gauravp446 commented Oct 29, 2021

Description

Added condition in Makefile to handle for windows environment

Motivation and Context

Resolves #123

Have you tested this? If so, how?

Yes i have tested this.
make_test_ss

Checklist for PR author(s)

  • Changes are covered by unit tests (no major decrease in code coverage %).
  • All tests pass.
  • Docstring coverage is 100% via interrogate drf_user (I mean, we should set a good example 😄).
  • Updates to documentation:
    • Document any relevant additions/changes in README.md.
    • Manually update both the README.md and docs/index.rst for any new changes.
    • Any changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives. Find the appropriate next version in the project's __init__.py file.

label=EPAM_INDIA_OSS_CONTRIBUTORS

@sumit4613
Copy link
Member

Hey, @gauravp446 thanks for working on this issue 🎉 . The changes look good, can you please do one more this before I merge this, can you please make a note in the CONTRIBUTING.MD file. Like how to install make in windows. You can insert a note after Local Development Environment heading. Thanks 🎉

image

@gauravp446
Copy link
Contributor Author

Hey, @gauravp446 thanks for working on this issue 🎉 . The changes look good, can you please do one more this before I merge this, can you please make a note in the CONTRIBUTING.MD file. Like how to install make in windows. You can insert a note after Local Development Environment heading. Thanks 🎉

image

Hi @sumit4613 I have added the steps in CONTRIBUTING.MD file for how to install make in windows.

@gauravp446 gauravp446 requested a review from sumit4613 October 30, 2021 08:54
Copy link
Member

@sumit4613 sumit4613 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @gauravp446 really sorry man, took this much time to merge this. Got busy at work that's why I forgot about this.

Thanks for working on that. Really appreciate this. 🎉
Welcome to drf-user.

Copy link
Member

@sumit4613 sumit4613 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 💯

@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #128 (99b2a8a) into master (6c11a3a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #128   +/-   ##
=======================================
  Coverage   95.68%   95.68%           
=======================================
  Files          20       20           
  Lines         649      649           
=======================================
  Hits          621      621           
  Misses         28       28           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c11a3a...99b2a8a. Read the comment docs.

@sumit4613 sumit4613 merged commit 8521a7d into 101Loop:master Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make file execution failing for windows.
2 participants