-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #123 : updated Makefile to support windows #128
Conversation
Hey, @gauravp446 thanks for working on this issue 🎉 . The changes look good, can you please do one more this before I merge this, can you please make a note in the |
Hi @sumit4613 I have added the steps in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, @gauravp446 really sorry man, took this much time to merge this. Got busy at work that's why I forgot about this.
Thanks for working on that. Really appreciate this. 🎉
Welcome to drf-user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 💯
Codecov Report
@@ Coverage Diff @@
## master #128 +/- ##
=======================================
Coverage 95.68% 95.68%
=======================================
Files 20 20
Lines 649 649
=======================================
Hits 621 621
Misses 28 28 Continue to review full report at Codecov.
|
Description
Added condition in Makefile to handle for windows environment
Motivation and Context
Resolves #123
Have you tested this? If so, how?
Yes i have tested this.

Checklist for PR author(s)
interrogate drf_user
(I mean, we should set a good example 😄).README.md
.README.md
anddocs/index.rst
for any new changes.versionadded
,versionchanged
, ordeprecated
directives. Find the appropriate next version in the project's__init__.py
file.label=EPAM_INDIA_OSS_CONTRIBUTORS