Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix makefile in docs section for html pages #122

Merged
merged 3 commits into from
Sep 20, 2021

Conversation

aayush-jaiswal
Copy link
Contributor

Description

Fixes issue #117

Have you tested this? If so, how?

Ran make html and docs generated

Checklist for PR author(s)

  • Changes are covered by unit tests (no major decrease in code coverage %).
  • All tests pass.
  • Docstring coverage is 100% via interrogate drf_user (I mean, we should set a good example 😄).
  • Updates to documentation:
    • Document any relevant additions/changes in README.md.
    • Manually update both the README.md and docs/index.rst for any new changes.
    • Any changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives. Find the appropriate next version in the project's __init__.py file.

@sumit4613 sumit4613 self-requested a review September 20, 2021 13:09
@codecov
Copy link

codecov bot commented Sep 20, 2021

Codecov Report

Merging #122 (f3dfd64) into master (887a312) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #122   +/-   ##
=======================================
  Coverage   95.68%   95.68%           
=======================================
  Files          20       20           
  Lines         649      649           
=======================================
  Hits          621      621           
  Misses         28       28           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 887a312...f3dfd64. Read the comment docs.

Copy link
Member

@sumit4613 sumit4613 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯 Thanks @aayush-jaiswal for working on this.

@sumit4613 sumit4613 merged commit 567cf6a into 101Loop:master Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants