Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve visibility of Redis counter #57

Merged
merged 15 commits into from
Oct 29, 2024
Merged

Improve visibility of Redis counter #57

merged 15 commits into from
Oct 29, 2024

Conversation

klaidliadon
Copy link
Contributor

@klaidliadon klaidliadon commented Oct 28, 2024 •
edited
Loading

Adding log to httprate redis plus some cleanup.

  • moved some types to internal package (duration, cycle store, usage tracker)
  • moved memory store to test package
  • replace error handler with option in middleware (like authcontrol)
  • use option logger in httprate redis onError and onFallback.

@klaidliadon klaidliadon changed the title Use httprate-redis logging Improv visibility of Redis counter Oct 28, 2024
@klaidliadon klaidliadon changed the title Improv visibility of Redis counter Improve visibility of Redis counter Oct 28, 2024
david-littlefarmer
david-littlefarmer reviewed Oct 29, 2024
View reviewed changes
Copy link
Contributor

@david-littlefarmer david-littlefarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1st round of CR

cache.go Outdated Show resolved Hide resolved
cache.go Outdated Show resolved Hide resolved
client.go Outdated Show resolved Hide resolved
handler.go Outdated Show resolved Hide resolved
internal/store/cycle.go Outdated Show resolved Hide resolved
internal/usage/usage.go Outdated Show resolved Hide resolved
middleware/middleware_permission.go Outdated Show resolved Hide resolved
middleware/middleware_quota.go Outdated Show resolved Hide resolved
middleware/middleware_ratelimit.go Outdated Show resolved Hide resolved
middleware/middleware_permission.go Outdated Show resolved Hide resolved
david-littlefarmer
david-littlefarmer reviewed Oct 29, 2024
View reviewed changes
Copy link
Contributor

@david-littlefarmer david-littlefarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last comment

config.go Outdated Show resolved Hide resolved
david-littlefarmer
david-littlefarmer approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@david-littlefarmer david-littlefarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klaidliadon klaidliadon merged commit feea23e into master Oct 29, 2024
1 check passed
@klaidliadon klaidliadon deleted the httprate-logger branch October 29, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-littlefarmer david-littlefarmer david-littlefarmer approved these changes

@VojtechVitek VojtechVitek Awaiting requested review from VojtechVitek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klaidliadon @david-littlefarmer