Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline selector lookup in TS abi-gen template #58

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Inline selector lookup in TS abi-gen template #58

merged 1 commit into from
Jan 20, 2022

Conversation

moodlezoup
Copy link
Contributor

Description

selector was colliding the selector parameters for the SimpleFunctionRegistryFeature methods 😦

Testing instructions

Types of changes

Checklist:

  • Prefix PR title with [WIP] if necessary.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

@moodlezoup moodlezoup force-pushed the fix/abi-gen/selector branch from cc8ed06 to ee25dd7 Compare January 20, 2022 00:21
dorothy-zbornak
dorothy-zbornak approved these changes Jan 20, 2022
View reviewed changes
Copy link
Contributor

@dorothy-zbornak dorothy-zbornak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh damn, we should probably prefix the local variables in the methods to avoid this happening again

@moodlezoup
Copy link
Contributor Author

oh damn, we should probably prefix the local variables in the methods to avoid this happening again

I guess we should probably just get rid of these functionSignature and functionSelector local variables all together and just inline it

@moodlezoup moodlezoup force-pushed the fix/abi-gen/selector branch from ee25dd7 to 167e242 Compare January 20, 2022 01:02
@moodlezoup
Copy link
Contributor Author

k I'm just going to inline selector and leave functionSignature bc I don't know what I'm doing in handlebars

@moodlezoup moodlezoup force-pushed the fix/abi-gen/selector branch from 167e242 to 902665b Compare January 20, 2022 01:04
@moodlezoup moodlezoup changed the title rename selector to functionSelector Inline selector logic in TS abi-gen template Jan 20, 2022
@moodlezoup moodlezoup changed the title Inline selector logic in TS abi-gen template Inline selector lookup in TS abi-gen template Jan 20, 2022
@moodlezoup moodlezoup merged commit a99370d into development Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorothy-zbornak dorothy-zbornak dorothy-zbornak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moodlezoup @dorothy-zbornak