more robust eth_signTypedData support #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0f24aab to
dd7d439
Compare
4 tasks
dd7d439 to
10e90e9
Compare
…vider` and use the method name passed in `@0x/web3-wrapper`: Remove `Web3Wrapper.signTypedDataV4Async()` and add backoff support for multiple versions of `eth_signTypedData` to `Web3Wrapper.signTypedDataAsync()`
10e90e9 to
7c3ded1
Compare
hysz
approved these changes
Jan 26, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on how you instantiate your providers (using provider engine or just a standardized provider), you can get inconsistent behavior when trying to perform an
eth_signTypedDataRPC call using MetaMask (+ probably other wallets). This attempts to make the behavior more consistent and more likely to succeed in different scenarios.eth_signTypedData_vXtoMetaMaskSubprovider.Web3Wrapper.signedTypeDataV4Async()eth_signTypedData_vXinWeb3Wrapper.signedTypeDataAsync().This will break the
protocol-utilspackage until it is updated to useWeb3Wrapper.signedTypeDataAsync()(previously usedWeb3Wrapper.signedTypeDataAsync()).Description
Testing instructions
Types of changes
Checklist:
[WIP]if necessary.