Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@0x/dev-utils: Add chainId opt to Web3Config #20

Merged
merged 1 commit into from
Jan 26, 2021
Merged

@0x/dev-utils: Add chainId opt to Web3Config #20

merged 1 commit into from
Jan 26, 2021

Conversation

dorothy-zbornak
Copy link
Contributor

@dorothy-zbornak dorothy-zbornak commented Jan 26, 2021 •
edited
Loading

Description

Also set the default chainId to 1337. This will break some tests in the protocol repo, which 0xProject/protocol#123 should fix.

Testing instructions

Types of changes

Checklist:

  • Prefix PR title with [WIP] if necessary.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

@dorothy-zbornak dorothy-zbornak requested a review from dekz as a code owner January 26, 2021 02:12
@dorothy-zbornak dorothy-zbornak force-pushed the feat/dev-utils/chainId-1337 branch 2 times, most recently from 0ee4ad4 to 732dda1 Compare January 26, 2021 02:14
@dorothy-zbornak dorothy-zbornak force-pushed the feat/dev-utils/chainId-1337 branch from 732dda1 to bebe011 Compare January 26, 2021 02:16
@dorothy-zbornak dorothy-zbornak mentioned this pull request Jan 26, 2021
Merged
6 tasks
hysz
hysz approved these changes Jan 26, 2021
View reviewed changes
Copy link
Contributor

@hysz hysz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm +1

moodlezoup
moodlezoup approved these changes Jan 26, 2021
View reviewed changes
Copy link
Contributor

@moodlezoup moodlezoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@dorothy-zbornak dorothy-zbornak merged commit 7778f30 into development Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moodlezoup moodlezoup moodlezoup approved these changes

@hysz hysz hysz approved these changes

@dekz dekz Awaiting requested review from dekz dekz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dorothy-zbornak @hysz @moodlezoup @merklejerk