Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for positive integer type on proof request query #350

Merged
merged 3 commits into from
Nov 23, 2023

Conversation

plusema86
Copy link
Contributor

Credential's positive integer claim are stored in the SDK as String, so a different filtering approach is needed.

  1. Bulk query based on credential type
  2. Manual filter based on query operator

emuroni added 2 commits November 23, 2023 13:05
positive integer are stored as String in the database, so we need a bulk response from database to be able to filter it manually
manually filter positive integer by query operators
Copy link
Contributor

@x1m3 x1m3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@x1m3 x1m3 changed the title Feature: Add support for positive integer type on proof request query feat: Add support for positive integer type on proof request query Nov 23, 2023
@plusema86 plusema86 merged commit 97cd8e8 into develop Nov 23, 2023
3 of 4 checks passed
@plusema86 plusema86 deleted the feature/PID1512-positive-integer-query-support branch November 23, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants