Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the second chapter #29

Merged
merged 23 commits into from
Jan 6, 2025
Merged

Rework the second chapter #29

merged 23 commits into from
Jan 6, 2025

Conversation

0xAX
Copy link
Owner

@0xAX 0xAX commented Jun 16, 2024

No description provided.

@0xAX 0xAX requested a review from klaudiagrz as a code owner June 16, 2024 15:41
@0xAX 0xAX force-pushed the chapter-2-update branch 3 times, most recently from 1fb2d95 to 3cd6f53 Compare June 16, 2024 15:46
@0xAX 0xAX force-pushed the chapter-2-update branch from 685b7ae to fc7c953 Compare July 17, 2024 12:02
@0xAX 0xAX mentioned this pull request Nov 3, 2024
0xAX added 6 commits November 29, 2024 02:12
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
Copy link
Collaborator

@klaudiagrz klaudiagrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments to README.md

Copy link
Collaborator

@klaudiagrz klaudiagrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments to sum.asm

0xAX added 2 commits December 25, 2024 16:39
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
Copy link
Collaborator

@klaudiagrz klaudiagrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of the blog post till the "Stack" section

0xAX added 2 commits December 26, 2024 01:30
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
Copy link
Collaborator

@klaudiagrz klaudiagrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More comments to sum.asm

Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
Copy link
Collaborator

@klaudiagrz klaudiagrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-check till "Stack"

0xAX added 3 commits December 27, 2024 17:12
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
Copy link
Collaborator

@klaudiagrz klaudiagrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of the Stack section

Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
Copy link
Collaborator

@klaudiagrz klaudiagrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

0xAX added 2 commits January 5, 2025 22:47
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
content/asm_2.md Outdated
- `IDIV` - Signed division
- `INC` - Increment
- `DEC` - Decrement
- `NEG` - Negation.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `NEG` - Negation.
- `NEG` - Negation

Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
@0xAX 0xAX merged commit f4a4294 into master Jan 6, 2025
1 check passed
@0xAX 0xAX deleted the chapter-2-update branch January 6, 2025 10:26
develoopeer pushed a commit to develoopeer/asm-ru that referenced this pull request Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants