Use typing.get_type_hints instead of .__annotations__ #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://docs.python.org/3/library/typing.html#typing.get_type_hints This properly resolves forward annotations, and fixes annotations when code uses `from __future__ import annotations` Cherry-picked to `before_v1` to help you out :)
|
LGTM. Will create a release later. |
|
|
Done! |
kemingy
approved these changes
Aug 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.python.org/3/library/typing.html#typing.get_type_hints
This properly resolves forward annotations, and fixes annotations when
code uses
from __future__ import annotationsCherry-picked to
before_v1to help you out :)I'd super appreciate a minor version or bugfix release with this