Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CON-2626 new exercise findspairs #2548

Merged
merged 2 commits into from
May 14, 2024
Merged

Conversation

MSilva95
Copy link
Member

@MSilva95 MSilva95 self-assigned this Apr 22, 2024
Copy link
Contributor

@nprimo nprimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add some extra information about "other invalid input" cases not specified in the options.

I would simplify the subject by expecting the input in the format of 2 arguments:

  1. A string of comma separated number (positive or negative). There could be more then one space between commas and number.
  2. A number specifying the target sum

subjects/findpairs/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@nprimo nprimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@MSilva95 MSilva95 merged commit cd19cd7 into master May 14, 2024
3 checks passed
@MSilva95 MSilva95 deleted the CON-2626-exercise-findspairs-readme branch May 14, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants