Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fea/sidebar api change #262

Merged
merged 23 commits into from
Apr 7, 2021
Merged

Fea/sidebar api change #262

merged 23 commits into from
Apr 7, 2021

Conversation

AjayThorve
Copy link
Member

@AjayThorve AjayThorve commented Apr 6, 2021 •
edited
Loading

This PR

  1. Implements a sidebar api for dashboard function, closes [FEA] API change for Panel Widget #256 :
d = cux_df.dashboard(charts=charts_list, sidebar=[widget_chart1, widget_chart2], layout_array=[
    [1, 1, 2, 2],
    [1, 1, 3, 4]
], theme=cuxfilter.themes.rapids, title="Layout - Custom")
  1. fixes [BUG] Layout Card Move Icon Hidden #259
  2. minor refactors wherever possible to use f-strings
  3. updates docs to reflect sidebar prop usage

@AjayThorve AjayThorve requested a review from a team as a code owner April 6, 2021 07:33
@github-actions github-actions bot added the Python label Apr 6, 2021
@AjayThorve AjayThorve marked this pull request as draft April 6, 2021 07:33
@AjayThorve AjayThorve marked this pull request as ready for review April 6, 2021 20:05
@github-actions github-actions bot added the doc Documentation label Apr 6, 2021
@AjayThorve AjayThorve added feature request New feature or request non-breaking Non-breaking change and removed doc Documentation labels Apr 6, 2021
@github-actions github-actions bot added the doc Documentation label Apr 6, 2021
@AjayThorve AjayThorve removed the feature request New feature or request label Apr 6, 2021
@AjayThorve
Copy link
Member Author

@gpucibot merge

@AjayThorve
Copy link
Member Author

Rerun tests

@rapids-bot rapids-bot bot merged commit d499b17 into rapidsai:branch-0.19 Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryevdv bryevdv bryevdv approved these changes

Assignees
No one assigned
Labels
doc Documentation non-breaking Non-breaking change Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Layout Card Move Icon Hidden [FEA] API change for Panel Widget
2 participants
@AjayThorve @bryevdv