Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with Manually Idle Notification Value command #1263

Closed
spudwebb opened this issue Aug 30, 2024 · 0 comments · Fixed by #1280
Closed

Issue with Manually Idle Notification Value command #1263

spudwebb opened this issue Aug 30, 2024 · 0 comments · Fixed by #1280

Comments

@spudwebb
Copy link

The doc here says the server supports the node.manually_idle_notification_value command with notificationType/prevValue/endpointIndex parameters, but looking at the code it seems it only supports the signature with a valueId

zwave-js-server/src/lib/node/message_handler.ts

Lines 274 to 276 in a39b42b

case NodeCommand.manuallyIdleNotificationValue: {
node.manuallyIdleNotificationValue(message.valueId);
return {};

could the signature with notificationType/prevValue/endpointIndex parameters be added ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support all signatures of node.manuallyIdleNotificationValue zwave-js/zwave-js-server
1 participant
@spudwebb