settings: Fixed spellchecker language selection #1290
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cyrilchukwuebuka please see https://zulip.readthedocs.io/en/latest/contributing/reviewable-prs.html and clean up the commit history; this PR is not ready for review as written. I notice one immediate visual issue: the dropdown's text look way too close to the left edge. Please spend some time polishing this before requesting a next review. |
|
Okay, I will do just that |
|
@timabbott, I have cleaned up the commit history and also added padding to the left edge of the dropdown text |
|
Thanks for the report @cyrilchukwuebuka! I’ve opted to fix the old UI in 0cb7297 rather than switching to a different UI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Fixed issue #1286
Any background context you want to provide?
I noticed using Tagify on the input fields makes the section behave in a weird manner.
So in f2972c0 I replaced it with a drop-down list of system-available language spellcheckers for users to select from without having to guess or input the wrong spellcheck language hereby making it easier for users to obviously know the list of available/supported languages to pick from thereby improving the user experience on the platform.
Screenshots?
You have tested this PR on: