Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.gitattributes ignored ??? #115

Open
lbdyck opened this issue Apr 1, 2024 · 8 comments
Open

.gitattributes ignored ??? #115

lbdyck opened this issue Apr 1, 2024 · 8 comments
Assignees

Comments

@lbdyck
Copy link

lbdyck commented Apr 1, 2024

This is my .gitattributes

# This .gitattributes file is autogenerated with zigi                                                
*                 git-encoding=iso8859-1 zos-working-tree-encoding=ibm-1047 linguist-language=REXX   
ZIGI/PANELS/*     git-encoding=iso8859-1 zos-working-tree-encoding=ibm-1047 linguist-language=PANELS 
.gitattributes    git-encoding=iso8859-1 zos-working-tree-encoding=iso8859-1                         
.gitignore        git-encoding=iso8859-1 zos-working-tree-encoding=iso8859-1                         
*.docm binary                                                                                        
*.docx binary                                                                                        
*.doc  binary                                                                                        
*.pdf  binary                                                                                        
*.epub binary                                                                                        
*.mobi binary                                                                                        
*.azw3 binary                                                                                        
*.pdf binary                                                                                         
ZIGI.PANELS/ZIGIEDIT git-encoding=BINARY zos-working-tree-encoding=BINARY binary           

When I cloned this repoistory the zigiedit was in the filesystem as text and not binary.

this is with git 2.44 - and this same issue with pdsegen:

PDSEGEN.PDS/CLS git-encoding=BINARY zos-working-tree-encoding=BINARY binary

@IgorTodorovskiIBM
Copy link
Collaborator

We don't support 'git-encoding=BINARY zos-working-tree-encoding=BINARY'. What happens if you remove that and keep the binary part?

And sorry I can't test it out myself at the moment (on vacation this week with no computer)

@lbdyck
Copy link
Author

lbdyck commented Apr 2, 2024

The .gitattributes doesa have just binary

example

CBTVIEW.PDS/UNZIPXMI git-encoding=BINARY zos-working-tree-encoding=BINARY binary

Enjoy your vacation

@lbdyck
Copy link
Author

lbdyck commented Apr 2, 2024

I removed the zos-working-tree-encoding=BINARY and now everything works fine with both the Rocket Git and the z/OS Open Tools Git. An update to zigi has been generated with a PR and I will be updating all my repositories that have this to remove it.

@lbdyck lbdyck closed this as completed Apr 2, 2024
@IgorTodorovskiIBM
Copy link
Collaborator

I'll leave this open because I think we should be ignoring the case where zos-working-tree-encoding is set to BINARY. I believe right now it detects that BINARY is not supported and stops, ignoring the following binary attribute.

@IgorTodorovskiIBM IgorTodorovskiIBM self-assigned this Apr 8, 2024
@IgorTodorovskiIBM
Copy link
Collaborator

Hmm, I cloned zigi and was not able to reproduce this:

ls -lT ./ZIGI.PANELS/ZIGIEDIT
b binary      T=off -rw-rw-r--   1 ITODORO  CDEV       13040 Apr  8 11:42 ./ZIGI.PANELS/ZIGIEDIT
[ITODORO@ZOSCAN2B ~/projects/zigi_def]$ file ./ZIGI.PANELS/ZIGIEDIT
./ZIGI.PANELS/ZIGIEDIT: binary data
[ITODORO@ZOSCAN2B ~/projects/zigi_def]$ git --version
git version 2.44.0
[ITODORO@ZOSCAN2B ~/projects/zigi_def]$ cat .gitattributes
# This .gitattributes file is autogenerated with zigi
*                 git-encoding=iso8859-1 zos-working-tree-encoding=ibm-1047 linguist-language=REXX
ZIGI/PANELS/*     git-encoding=iso8859-1 zos-working-tree-encoding=ibm-1047 linguist-language=PANELS
.gitattributes    git-encoding=iso8859-1 zos-working-tree-encoding=iso8859-1
.gitignore        git-encoding=iso8859-1 zos-working-tree-encoding=iso8859-1
*.docm binary
*.docx binary
*.doc  binary
*.pdf  binary
*.epub binary
*.mobi binary
*.azw3 binary
*.pdf binary
ZIGI.PANELS/ZIGIEDIT git-encoding=BINARY zos-working-tree-encoding=BINARY binary

@lbdyck
Copy link
Author

lbdyck commented Apr 8, 2024

Did you check ZIGI.PANELS/ZIGIEDIT git-encoding=BINARY zos-working-tree-encoding=BINARY binary ?

@IgorTodorovskiIBM
Copy link
Collaborator

This was after cloning https://github.com/zigi/zigi.git. I checked the attribute using chtag and looked at the .gitattributes file. Is there another way to check?

@IgorTodorovskiIBM
Copy link
Collaborator

@lbdyck - is this still an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants