fix(index): set default hashAlgorithm

omfg config really needs to be more centralized soon
zkat · Mar 13, 2017 · d6eb2f0 · d6eb2f0
1 parent 2318a8f
commit d6eb2f0
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/lib/entry-index.js b/lib/entry-index.js
@@ -36,7 +36,7 @@ function insert (cache, key, digest, opts) {
     const entry = {
       key: key,
       digest: digest,
-      hashAlgorithm: opts.hashAlgorithm,
+      hashAlgorithm: opts.hashAlgorithm || 'sha512',
       time: +(new Date()),
       metadata: opts.metadata
     }

diff --git a/test/index.insert.js b/test/index.insert.js
@@ -63,10 +63,12 @@ test('inserts additional entries into existing key', function (t) {
     t.deepEqual(entries, [{
       key: KEY,
       digest: DIGEST,
+      hashAlgorithm: 'sha512',
       metadata: 1
     }, {
       key: KEY,
       digest: DIGEST,
+      hashAlgorithm: 'sha512',
       metadata: 2
     }], 'all entries present')
   })
@@ -91,7 +93,8 @@ test('separates entries even if one is corrupted', function (t) {
     delete entry.time
     t.deepEqual(entry, {
       key: KEY,
-      digest: DIGEST
+      digest: DIGEST,
+      hashAlgorithm: 'sha512'
     }, 'new entry unaffected by corruption')
   })
 })
@@ -108,6 +111,7 @@ test('optional arbitrary metadata', function (t) {
     t.deepEqual(entry, {
       key: KEY,
       digest: DIGEST,
+      hashAlgorithm: 'sha512',
       metadata: metadata
     }, 'entry includes inserted metadata')
   })
@@ -155,7 +159,8 @@ test('path-breaking characters', function (t) {
     delete entry.time
     t.deepEqual(entry, {
       key: newKey,
-      digest: DIGEST
+      digest: DIGEST,
+      hashAlgorithm: 'sha512'
     }, 'entry exists and matches original key with invalid chars')
   })
 })
@@ -175,7 +180,8 @@ test('extremely long keys', function (t) {
     delete entry.time
     t.deepEqual(entry, {
       key: newKey,
-      digest: DIGEST
+      digest: DIGEST,
+      hashAlgorithm: 'sha512'
     }, 'entry exists in spite of INCREDIBLY LONG key')
   })
 })