Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rp: make Userinfo and IntrospectionResponse generic #313

Closed
2 tasks done
muhlemmer opened this issue Mar 8, 2023 · 2 comments · Fixed by #389
Closed
2 tasks done

rp: make Userinfo and IntrospectionResponse generic #313

muhlemmer opened this issue Mar 8, 2023 · 2 comments · Fixed by #389
Assignees
@muhlemmer
Labels
backend client pkg/client/* issues enhancement New feature or request released on @next released
Milestone
v3

Comments

@muhlemmer
Copy link
Collaborator

muhlemmer commented Mar 8, 2023 •
edited
Loading

As a developer I want to be able to choose the return type in Userinfo and Introspection responses. This allows me type-safe access to custom fields, instead of the current Claims map.

This change would be similar to the change done on the Token Claims family of types in #283.

Acceptance criteria

  • Functions currently returning or interacting with UserInfo and IntrospectionReponse in the rp and client packages will be made generic.
  • Examples how to use these generics with custom types.
@muhlemmer muhlemmer added enhancement New feature or request backend labels Mar 8, 2023
@hifabienne hifabienne moved this to 📝 Prioritized Product Backlog in Product Management Mar 17, 2023
@hifabienne hifabienne moved this from 📝 Prioritized Product Backlog to 🔖 Ready in Product Management Apr 6, 2023
@adlerhurst adlerhurst moved this from 🔖 Ready to 📋 Sprint Backlog in Product Management Apr 12, 2023
@muhlemmer muhlemmer mentioned this issue Apr 18, 2023
Closed
@muhlemmer muhlemmer moved this from 📋 Sprint Backlog to 🏗 In progress in Product Management Apr 18, 2023
@muhlemmer muhlemmer added this to the v3 milestone Apr 22, 2023
@muhlemmer muhlemmer added go Pull requests that update Go code client pkg/client/* issues and removed go Pull requests that update Go code labels Apr 22, 2023
@muhlemmer muhlemmer mentioned this issue May 4, 2023
Merged
@muhlemmer muhlemmer linked a pull request May 4, 2023 that will close this issue
feat: generic Userinfo and Introspect functions #389
Merged
@muhlemmer muhlemmer moved this from 🏗 In progress to 👀 In review in Product Management May 4, 2023
@livio-a livio-a closed this as completed May 5, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Product Management May 5, 2023
@github-actions
Copy link

github-actions bot commented May 5, 2023

🎉 This issue has been resolved in version 3.0.0-next.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This issue has been resolved in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muhlemmer muhlemmer

Labels
backend client pkg/client/* issues enhancement New feature or request released on @next released
Projects
None yet
Milestone
v3
Development

Successfully merging a pull request may close this issue.

feat: generic Userinfo and Introspect functions zitadel/oidc
2 participants
@muhlemmer @livio-a