From 8b395fb7323487f4548f287ec0f4511f7a0f95dd Mon Sep 17 00:00:00 2001 From: Tom Lee Date: Sun, 2 Aug 2020 10:36:39 -0700 Subject: [PATCH 1/2] Checkin pending Discovering Rooms features spec --- features/discovering-rooms.feature | 39 ++++++++++++++++++++++++++++++ 1 file changed, 39 insertions(+) create mode 100644 features/discovering-rooms.feature diff --git a/features/discovering-rooms.feature b/features/discovering-rooms.feature new file mode 100644 index 000000000..99e680f49 --- /dev/null +++ b/features/discovering-rooms.feature @@ -0,0 +1,39 @@ +@wip +Feature: Discovering Rooms + In order to interact with other people in a Workspace + I want to be able to explore the Workspace's rooms + +Scenario: Workspace Member may discover Listed Room + Given a Workspace with a Listed Room + When a Workspace Member is on the Workspace Dashboard + Then they see the Room + +Scenario: Workspace Member may not discover Unlisted Room + Given a Workspace with an Unlisted Room + When a Workspace Member is on the Workspace Dashboard + Then they do not see the Room + +Scenario: Room Creator may discover Unlisted Room + Given a Workspace with an Unlisted Room + When the Room Creator is on the Workspace Dashboard + Then they see the Room + +Scenario: Room Previous Attendee may discover previously visited Unlisted Room + Given a Workspace with an Unlisted Room + When a Previous Attendee of that Room is on the Workspace Dashboard + Then they see the Room + +Scenario: Guest may discover Listed Room + Given a Workspace with a Listed Room + When a Guest is on the Workspace Dashboard + Then they see the Room + +Scenario: Guest may not discover Unlisted Room + Given a Workspace with an Unlisted Room + When a Guest is on the Workspace Dashboard + Then they do not see the Room + +Scenario: Guest may not discover Listed Internal Room + Given a Workspace with an Listed Internal Room + When a Guest is on the Workspace Dashboard + Then they do not see the Room \ No newline at end of file From cfbb4e45b1a7c3a66e77e6463eb3b49d1958eca7 Mon Sep 17 00:00:00 2001 From: Zee <50284+zspencer@users.noreply.github.com> Date: Sun, 2 Aug 2020 18:08:53 -0700 Subject: [PATCH 2/2] Discovering Rooms feature file reflects state of system Now that Tom has removed Unlisted Rooms from the Workspace show page, I have updated the feature file to indicate which scenarios work but are missing functional step definitions. See: https://github.com/zinc-collective/convene/issues/39 See: https://github.com/zinc-collective/convene/pull/60 --- features/discovering-rooms.feature | 64 ++++++++++++++++-------------- package.json | 2 +- 2 files changed, 36 insertions(+), 30 deletions(-) diff --git a/features/discovering-rooms.feature b/features/discovering-rooms.feature index 99e680f49..13dca69a9 100644 --- a/features/discovering-rooms.feature +++ b/features/discovering-rooms.feature @@ -1,39 +1,45 @@ -@wip Feature: Discovering Rooms In order to interact with other people in a Workspace I want to be able to explore the Workspace's rooms -Scenario: Workspace Member may discover Listed Room - Given a Workspace with a Listed Room - When a Workspace Member is on the Workspace Dashboard - Then they see the Room + @unimplemented-steps + Scenario: Workspace Member may discover Listed Room + Given a Workspace with a Listed Room + When a Workspace Member is on the Workspace Dashboard + Then they see the Room -Scenario: Workspace Member may not discover Unlisted Room - Given a Workspace with an Unlisted Room - When a Workspace Member is on the Workspace Dashboard - Then they do not see the Room + @unimplemented-steps + Scenario: Workspace Member may not discover Unlisted Room + Given a Workspace with an Unlisted Room + When a Workspace Member is on the Workspace Dashboard + Then they do not see the Room -Scenario: Room Creator may discover Unlisted Room - Given a Workspace with an Unlisted Room - When the Room Creator is on the Workspace Dashboard - Then they see the Room + @unstarted + Scenario: Room Creator may discover Unlisted Room + Given a Workspace with an Unlisted Room + When the Room Creator is on the Workspace Dashboard + Then they see the Room -Scenario: Room Previous Attendee may discover previously visited Unlisted Room - Given a Workspace with an Unlisted Room - When a Previous Attendee of that Room is on the Workspace Dashboard - Then they see the Room + @unstarted + Scenario: Room Previous Attendee may discover previously visited Unlisted Room + Given a Workspace with an Unlisted Room + When a Previous Attendee of that Room is on the Workspace Dashboard + Then they see the Room -Scenario: Guest may discover Listed Room - Given a Workspace with a Listed Room - When a Guest is on the Workspace Dashboard - Then they see the Room + @unimplemented-steps + Scenario: Guest may discover Listed Room + Given a Workspace with a Listed Room + When a Guest is on the Workspace Dashboard + Then they see the Room -Scenario: Guest may not discover Unlisted Room - Given a Workspace with an Unlisted Room - When a Guest is on the Workspace Dashboard - Then they do not see the Room + @unimplemented-steps + Scenario: Guest may not discover Unlisted Rooms + Given a Workspace with an Unlisted Room + When a Guest is on the Workspace Dashboard + Then they do not see the Room -Scenario: Guest may not discover Listed Internal Room - Given a Workspace with an Listed Internal Room - When a Guest is on the Workspace Dashboard - Then they do not see the Room \ No newline at end of file + @unstarted + Scenario: Guest may not discover Listed Internal Room + Given a Workspace with an Listed Internal Room + When a Guest is on the Workspace Dashboard + Then they do not see the Room \ No newline at end of file diff --git a/package.json b/package.json index ec32b4f81..2acc5cedc 100644 --- a/package.json +++ b/package.json @@ -4,7 +4,7 @@ "description": "Community owned tools that bring people together, both online and off", "main": "index.js", "scripts": { - "test": "cucumber-js --tags 'not @unscheduled and not @wip'" + "test": "cucumber-js --tags 'not @unscheduled and not @wip and not @unimplemented-steps and not @unstarted'" }, "repository": { "type": "git",