From e056f9f548aa0fae903decaaa8de8ef78cfcf29c Mon Sep 17 00:00:00 2001
From: David Cui <53581635+davidcui-amzn@users.noreply.github.com>
Date: Fri, 18 Dec 2020 12:19:30 -0800
Subject: [PATCH] Configure Max Size for Dashboards API & Minor UI Changes
 (#266)

---
 .../report_settings.test.tsx.snap             | 24 -------------------
 .../report_settings/report_settings.tsx       |  1 -
 .../report_trigger/report_trigger.tsx         |  2 +-
 kibana-reports/server/routes/reportSource.ts  |  1 +
 4 files changed, 2 insertions(+), 26 deletions(-)

diff --git a/kibana-reports/public/components/report_definitions/report_settings/__tests__/__snapshots__/report_settings.test.tsx.snap b/kibana-reports/public/components/report_definitions/report_settings/__tests__/__snapshots__/report_settings.test.tsx.snap
index 41cfd11c..8e27bca8 100644
--- a/kibana-reports/public/components/report_definitions/report_settings/__tests__/__snapshots__/report_settings.test.tsx.snap
+++ b/kibana-reports/public/components/report_definitions/report_settings/__tests__/__snapshots__/report_settings.test.tsx.snap
@@ -1055,9 +1055,6 @@ exports[`<ReportSettings /> panel dashboard create from in-context 1`] = `
         </div>
       </div>
     </div>
-    <div
-      class="euiSpacer euiSpacer--l"
-    />
   </div>
 </div>
 `;
@@ -2124,9 +2121,6 @@ exports[`<ReportSettings /> panel display errors on create 1`] = `
         </div>
       </div>
     </div>
-    <div
-      class="euiSpacer euiSpacer--l"
-    />
   </div>
 </div>
 `;
@@ -2609,9 +2603,6 @@ exports[`<ReportSettings /> panel render component 1`] = `
         />
       </div>
     </div>
-    <div
-      class="euiSpacer euiSpacer--l"
-    />
   </div>
 </div>
 `;
@@ -3112,9 +3103,6 @@ exports[`<ReportSettings /> panel render edit, dashboard source 1`] = `
         />
       </div>
     </div>
-    <div
-      class="euiSpacer euiSpacer--l"
-    />
   </div>
 </div>
 `;
@@ -3615,9 +3603,6 @@ exports[`<ReportSettings /> panel render edit, saved search source 1`] = `
         />
       </div>
     </div>
-    <div
-      class="euiSpacer euiSpacer--l"
-    />
   </div>
 </div>
 `;
@@ -4118,9 +4103,6 @@ exports[`<ReportSettings /> panel render edit, visualization source 1`] = `
         />
       </div>
     </div>
-    <div
-      class="euiSpacer euiSpacer--l"
-    />
   </div>
 </div>
 `;
@@ -5180,9 +5162,6 @@ exports[`<ReportSettings /> panel saved search create from in-context 1`] = `
         </div>
       </div>
     </div>
-    <div
-      class="euiSpacer euiSpacer--l"
-    />
   </div>
 </div>
 `;
@@ -6242,9 +6221,6 @@ exports[`<ReportSettings /> panel visualization create from in-context 1`] = `
         </div>
       </div>
     </div>
-    <div
-      class="euiSpacer euiSpacer--l"
-    />
   </div>
 </div>
 `;
diff --git a/kibana-reports/public/components/report_definitions/report_settings/report_settings.tsx b/kibana-reports/public/components/report_definitions/report_settings/report_settings.tsx
index 6441612b..5ee6a649 100644
--- a/kibana-reports/public/components/report_definitions/report_settings/report_settings.tsx
+++ b/kibana-reports/public/components/report_definitions/report_settings/report_settings.tsx
@@ -689,7 +689,6 @@ export function ReportSettings(props: ReportSettingProps) {
         />
         <EuiSpacer />
         {displayVisualReportsFormatAndMarkdown}
-        <EuiSpacer />
       </EuiPageContentBody>
     </EuiPageContent>
   );
diff --git a/kibana-reports/public/components/report_definitions/report_trigger/report_trigger.tsx b/kibana-reports/public/components/report_definitions/report_trigger/report_trigger.tsx
index 9ceede60..006bc07b 100644
--- a/kibana-reports/public/components/report_definitions/report_trigger/report_trigger.tsx
+++ b/kibana-reports/public/components/report_definitions/report_trigger/report_trigger.tsx
@@ -479,7 +479,7 @@ export function ReportTrigger(props: ReportTriggerProps) {
           error={'Invalid cron expression.'}
           labelAppend={
             <EuiText size="xs">
-              <EuiLink href="https://opendistro.github.io/for-elasticsearch-docs/docs/alerting/cron/" target="_blank">
+              <EuiLink href="https://opendistro.github.io/for-elasticsearch-docs/docs/alerting/cron/" target="_blank" external={true}>
                 Cron help
               </EuiLink>
             </EuiText>
diff --git a/kibana-reports/server/routes/reportSource.ts b/kibana-reports/server/routes/reportSource.ts
index d43bc471..f628ac13 100644
--- a/kibana-reports/server/routes/reportSource.ts
+++ b/kibana-reports/server/routes/reportSource.ts
@@ -44,6 +44,7 @@ export default function (router: IRouter) {
         const params: RequestParams.Search = {
           index: '.kibana',
           q: 'type:dashboard',
+          size: DEFAULT_MAX_SIZE,
         };
         responseParams = params;
       } else if (request.params.reportSourceType === 'visualization') {