Add minimal phpunit run in GitHub Actions #44
Conversation
.github/workflows/tests.yml
Outdated
| - "7.1" | ||
| - "7.2" | ||
| - "7.3" | ||
| - "7.4" | ||
| - "8.0" |
There was a problem hiding this comment.
Something funny happens, PHPUnit shows progress until 89%:
the output contains several E-s, but the build is successful! this is not good.
There was a problem hiding this comment.
I've ended up running same tests locally via docker, and there phpunit stops at 90%
There was a problem hiding this comment.
@falkenhawk what you think of disabling 8.0 for github actions, I ended up cherry-picking commits from the 8.0 branch, and seems it's still having issues. I don't want to make the PR itself very big, but rather make several PR's that are easier review and merge. possibly doing things in parallel, once there's basic phpunit invocation present.
or alternatively, can just ignore errors from 8.0 phpunit, merge with failing pipeline.
I propose making this PR exclude any issues with 8.0 (deal them later), either by removing 8.0 or consciously ignoring errors from 8.0 job.
ps: github actions does not have "allow_failure" equivalent yet. I've been tracking this issue for it: https://github.com/actions/toolkit/issues/399.
your input needed how to proceed.
There was a problem hiding this comment.
my next PR plans(after this PR) are (from #34):
- add locale tests and locale fixes
- add services, mysql, pgsql
There was a problem hiding this comment.
wow I greatly appreciate your dedication.
Let's skip 8.0 for now and ditch any compatibility fixes needed for 8.0 here and deal with that in a separate PR, possibly branched off the 8.0 compatibility patch branch.
Having the whole pipeline running for php 5.3-7.4 on GHA would be awesome, as the first step. I asked travis for free OSS credits 2 weeks ago - because the jobs are currently not running at all due to depleted credits - and still no answer 🤷♂️
There was a problem hiding this comment.
Oh, didn't know Travis OSS credits have been limited, I'm not following the news apparently.
There was a problem hiding this comment.
Seems that enabling locales broken sql tests:
so, need to enable sql testing next, then locales testing
78eb4f3 to
7f77b8c
Compare
7f77b8c to
8247c9c
Compare
|
Updated to test only 5.3 to 7.4 |
|
haven't checked those |
|
I haven't seen them before, but it's okay to check them later. |
* upstream/master: Add minimal phpunit run in GitHub Actions (zf1s#44) Conflicts: .github/workflows/tests.yml
|
@falkenhawk please could you not do squash merges, please! |
|
Okay I will keep that in mind, but could you tell me please why you don't like it? In this case I thought it's fine to have only one nice commit |
Adds minimal PHPUnit invocation. Most of the tests are Skipped.
Tests PHP 5.3-7.4, PHP 8.0 is removed.
Extracted from #34