Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php 8.1 compat: ReturnTypeWillChange Attribute #147

Merged
merged 4 commits into from
Nov 28, 2022
Merged

php 8.1 compat: ReturnTypeWillChange Attribute #147

merged 4 commits into from
Nov 28, 2022

Conversation

falkenhawk
Copy link
Member

@falkenhawk falkenhawk commented Nov 23, 2022 •
edited
Loading

replaces #120 & #141
fixes #125

@falkenhawk falkenhawk mentioned this pull request Nov 23, 2022
Closed
@falkenhawk
bump zf1s/phpunit again to 3.7.41
c85eec4 
revert regression from 6f8e98e where it was downgraded to 3.7.40 by mistake
@glensc
Copy link
Contributor

glensc commented Nov 23, 2022

How do you even read out from the massive output what test failed?

@falkenhawk falkenhawk mentioned this pull request Nov 23, 2022
Merged
@falkenhawk falkenhawk force-pushed the php81-compat-returntypewillchange branch from 952637a to d7ba9c8 Compare November 23, 2022 20:37
@falkenhawk
Copy link
Member Author

falkenhawk commented Nov 24, 2022 •
edited
Loading

I had to fork and adjust yet another ancient package to make the tests go on php 8.1 without fatal errors
zf1s/dbunit#1

but still there is a long way to go for php 8.1 compatibility
https://github.com/zf1s/zf1/actions/runs/3535509276/jobs/5933609176
There were 1141 errors: and 33 failures (and additionally a bunch of deprecation warnings)

@falkenhawk falkenhawk marked this pull request as ready for review November 28, 2022 14:58
@falkenhawk falkenhawk merged commit 9d61914 into master Nov 28, 2022
@falkenhawk falkenhawk deleted the php81-compat-returntypewillchange branch November 28, 2022 17:24
@falkenhawk falkenhawk mentioned this pull request Dec 3, 2022
Merged
@falkenhawk falkenhawk mentioned this pull request Dec 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcing marcing Awaiting requested review from marcing

@partikus partikus Awaiting requested review from partikus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resolve or suppress PHP 8.1 deprecation notices
3 participants
@falkenhawk @glensc @jack-worman