Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use mysql v5.7 in gha #115

Merged
merged 1 commit into from
Oct 1, 2021
Merged

use mysql v5.7 in gha #115

merged 1 commit into from
Oct 1, 2021

Conversation

falkenhawk
Copy link
Member

instead of v5.6

@falkenhawk falkenhawk changed the title use mysql to v5.7 in gha use mysql v5.7 in gha Oct 1, 2021
@marcing marcing self-requested a review October 1, 2021 15:08
@falkenhawk falkenhawk merged commit 427bbce into master Oct 1, 2021
@glensc
Copy link
Contributor

glensc commented Oct 3, 2021

please fill reasoning why? I kept the lowest version to have the most compatible tests.

@falkenhawk
Copy link
Member Author

simply because I believe 5.7 is more popular than 5.6 - i could not find any charts or usage statistics though.
I also similarly picked postgres v12 in #114 . I know ideally it would be to add a matrix of versions, but I did not want to invest more time to this.

@falkenhawk
Copy link
Member Author

falkenhawk commented Oct 4, 2021 •
edited
Loading

Still it would be worth it to test both mysql v5.x and v8.x...

@falkenhawk falkenhawk deleted the gha-mysql-57 branch October 15, 2021 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcing marcing marcing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@falkenhawk @glensc @marcing