Skip to content

Commit

Permalink
Fix Zend_Form_ElementTest
Browse files Browse the repository at this point in the history
The behaviour hasn't really changed because the intent of the test is to
use an array of arrays in setOptions. What has changed is that PHP 8.0
supports calling functions with named parameters and will throw a Fatal
if you try to access a parameter by name that does not exist.
Digits::__construct has no param named bar ergo we get a Fatal.
  • Loading branch information
Alexander Wozniak authored and glensc committed Mar 15, 2021
1 parent 7d4652d commit 985e0b9
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions tests/Zend/Form/ElementTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,11 @@
*/
class Zend_Form_ElementTest extends PHPUnit_Framework_TestCase
{
/**
* @var Zend_Form_Element
*/
private $element;

public static function main()
{
$suite = new PHPUnit_Framework_TestSuite('Zend_Form_ElementTest');
Expand Down Expand Up @@ -1760,12 +1765,12 @@ public function testSetOptionsSetsArrayOfArrayFilters()

$options = $this->getOptions();
$options['filters'] = array(
array('Digits', array('bar' => 'baz')),
array('Alnum', array('allowWhiteSpace' => true)),
array('Alpha', array('foo')),
);
$this->element->setOptions($options);
$filter = $this->element->getFilter('Digits');
$this->assertTrue($filter instanceof Zend_Filter_Digits);
$filter = $this->element->getFilter('Alnum');
$this->assertTrue($filter instanceof Zend_Filter_Alnum);
$filter = $this->element->getFilter('Alpha');
$this->assertTrue($filter instanceof Zend_Filter_Alpha);
}
Expand Down

0 comments on commit 985e0b9

Please sign in to comment.