Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup travis with php lint for 5.3-7.3 #3

Closed
wants to merge 1 commit into from
Closed

setup travis with php lint for 5.3-7.3 #3

wants to merge 1 commit into from

Conversation

glensc
Copy link
Collaborator

@glensc glensc commented May 6, 2019 •
edited
Loading

@falkenhawk
Copy link
Member

to be replaced with zf1s/zf1#4

@falkenhawk falkenhawk closed this May 18, 2019
falkenhawk added a commit that referenced this pull request Oct 1, 2021
@falkenhawk
[zend-loader] refactor broken resolvePharParentPath static method
273fb45 
(which never worked properly anyway because of that `if ($value !== '...') return` condition)
into an inline foreach loop which discards '..' values from path parts array, in a way that also previous part is discarded when '..' is found.

This also fixes `Zend_Loader_ClassMapAutoloader::resolvePharParentPath(): Argument #3 ($parts) must be passed by reference, value given` error on php8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glensc @falkenhawk