Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] Fix bootstrap import in the theme #172

Closed
zetxek opened this issue Jan 26, 2025 · 0 comments · Fixed by #173
Closed

[enhancement] Fix bootstrap import in the theme #172

zetxek opened this issue Jan 26, 2025 · 0 comments · Fixed by #173
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@zetxek
Copy link
Owner

zetxek commented Jan 26, 2025

Describe the bug

Currently the bootstrap files are modified by hand to integrate into the theme, by renaming the "vendor" folder:

This is wrong- it was just the "quick and dirty" fix for the encountered issue where "vendor" is a reserved folder name: #166 (comment)

As suggested by @mnordhaus in #165 (comment) we should look into a better way to integrate the dependency, following bootstrap advice.

The idea would be to use package.json for the vendoring.
A requirement is that the theme should still be usable "batteries included" as a git submodule (https://github.com/zetxek/adritian-git-submodule-demo can be used as a demo/test environment).

@zetxek zetxek added the bug Something isn't working label Jan 26, 2025
@zetxek zetxek self-assigned this Jan 26, 2025
@zetxek zetxek added the enhancement New feature or request label Jan 26, 2025
@zetxek zetxek changed the title [BUG] Fix bootstrap import in the theme [enhancement] Fix bootstrap import in the theme Jan 26, 2025
@zetxek zetxek linked a pull request Jan 26, 2025 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant