Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fungible module call revert #344

Closed
3 tasks done
Tracked by #692
brewmaster012 opened this issue Nov 25, 2022 · 1 comment
Closed
3 tasks done
Tracked by #692

Fungible module call revert #344

brewmaster012 opened this issue Nov 25, 2022 · 1 comment
Assignees
@brewmaster012
Labels
epic Group issues under a high-level objective m:fungible

Comments

@brewmaster012
Copy link
Collaborator

brewmaster012 commented Nov 25, 2022 •
edited by fadeev
Loading

Currently when inbound CCTX calls zEVM and fails, then the cctx goes directly into "aborted".

Should have refunded the fungible tokens user sent in, less the gas fees + withdraw fees.

Proposed solution

Tasks
Preview Give feedback
  1. bug: calling zEVM contract from external chains via SystemContract does not return revert string #742
    brewmaster012
  2. refactor(fungible): contract invocation from external chains #725
    refactor
    brewmaster012
  3. fix: refund inbound tx if omni-chain smart contract call reverts #749
@brewmaster012 brewmaster012 added the feature:idea An early idea for a feature. Used as reference to follow new feature integrations label Nov 25, 2022
@brewmaster012 brewmaster012 changed the title zEVM module call revert fungible module call revert Feb 16, 2023
@fadeev fadeev added the epic Group issues under a high-level objective label Jun 7, 2023
@fadeev fadeev changed the title fungible module call revert Fungible module call revert Jun 7, 2023
This was referenced Jun 7, 2023
Closed
Closed
@fadeev fadeev removed the feature:idea An early idea for a feature. Used as reference to follow new feature integrations label Jun 8, 2023
@fadeev fadeev added the blocked label Jun 19, 2023
@fadeev
Copy link
Member

fadeev commented Jun 19, 2023 •
edited
Loading

Blocked by refactoring in the fungible module.

@fadeev fadeev removed the blocked label Jul 25, 2023
@fadeev fadeev closed this as completed Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brewmaster012 brewmaster012

Labels
epic Group issues under a high-level objective m:fungible
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fadeev @brewmaster012