Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sender chain check in processFailedOutboundV2 #3165

Closed
lumtis opened this issue Nov 15, 2024 · 0 comments · Fixed by #3166
Closed

Remove sender chain check in processFailedOutboundV2 #3165

lumtis opened this issue Nov 15, 2024 · 0 comments · Fixed by #3166
Labels
bug Something isn't working m:crosschain

Comments

@lumtis
Copy link
Member

lumtis commented Nov 15, 2024

Describe the Issue

Here

if cctx.InboundParams.SenderChainId != zetaChain.ChainId {

This check is invalid and doesn't add added security.
A revert outbound is processed the same as a regular outbound and uses this function.
Revert outbound has the external chain as sender chain. The result is that for failed revert outbound, this check will not pass and abort but with a message like sender chain for withdraw cctx is not ZetaChain expected 7001 got 84532

The check should be removed to have a clearer error message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working m:crosschain
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant