New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all panics in message types #2592

Open

lumtis opened this issue Jul 30, 2024 · 0 comments

Labels

refactor zetacore

Member

lumtis commented Jul 30, 2024

Describe the Issue
Original discussion: #2578 (comment)

It doesn't seem the panic are necessary in the code and not used in Cosmos SDK: https://github.com/cosmos/cosmos-sdk/blob/44c5d17ca6d9d37fdd6adfa3169c986fbce22b8f/x/bank/types/msgs.go#L63

Outcome

Do some assessment on implication of removing panics, and remove them if this make sense

lumtis added zetacore refactor labels

lumtis mentioned this issue

feat(fungible): add Gateway address in protocol contract list #2578

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment