Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove the constant maxHeightDiff and let chain client continue scan from where it left off #2086

Closed
Tracked by #1611
ws4charlie opened this issue Apr 26, 2024 · 0 comments · Fixed by #2222
Closed
Tracked by #1611

remove the constant maxHeightDiff and let chain client continue scan from where it left off #2086

ws4charlie opened this issue Apr 26, 2024 · 0 comments · Fixed by #2222
Assignees
@ws4charlie
Labels
bug Something isn't working

Comments

@ws4charlie
Copy link
Contributor

Describe the Issue
We have a hard-coded maxHeightDiff to allow bitcoin client to skip blocks if there is big gap > maxHeightDiff between last scanned height and latest bitcoin height. This logic could cause missed inbound txs in mainnet.

Expected Outcome
A description of what outcome you are seeking.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ws4charlie ws4charlie

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: removed maxHeightDiff to let observer scan Bitcoin block from where it left off zeta-chain/node
1 participant
@ws4charlie