Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing panic in zetaclient #2024

Closed
Tracked by #1611
lumtis opened this issue Apr 15, 2024 · 0 comments · Fixed by #2210
Closed
Tracked by #1611

Removing panic in zetaclient #2024

lumtis opened this issue Apr 15, 2024 · 0 comments · Fixed by #2210
Assignees
@ws4charlie
Labels
zetaclient Issues related to ZetaClient

Comments

@lumtis
Copy link
Member

lumtis commented Apr 15, 2024

Describe the Issue

  • Return a proper error instead of panicking in the main packages
  • For the test files, rely on the require package and testing.T object to correctly handle assertion failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ws4charlie ws4charlie

Labels
zetaclient Issues related to ZetaClient
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: removed uncessary panics in zetaclientd process zeta-chain/node
2 participants
@lumtis @ws4charlie