Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make UpdateConfigFromCore and ZetaClient config more future-proof #1397

Closed
Tracked by #1611
lumtis opened this issue Nov 15, 2023 · 0 comments · Fixed by #2907
Closed
Tracked by #1611

Make UpdateConfigFromCore and ZetaClient config more future-proof #1397

lumtis opened this issue Nov 15, 2023 · 0 comments · Fixed by #2907
Labels
zetaclient Issues related to ZetaClient

Comments

@lumtis
Copy link
Member

lumtis commented Nov 15, 2023

UpdateConfigFromCore currently considers there is a single Bitcoin chain supported in ZetaClient and a chain is now a Bitcoin chain is an EVM chain

if common.IsBitcoinChain(coreParam.ChainId) {
	newBTCParams = coreParam
} else {
	newEVMParams[coreParam.ChainId] = coreParam
}

I suggest to update the format of the ZetaClient config with more like a generic list of chains, so we can consider several Bitcoin based chains and any other chains compared to EVM chains

@lumtis lumtis added the zetaclient Issues related to ZetaClient label Nov 15, 2023
@lumtis lumtis changed the title Make UpdateConfigFromCore more future-proof Make UpdateConfigFromCore and ZetaClient config more future-proof Nov 15, 2023
@skosito skosito self-assigned this Apr 24, 2024
@skosito skosito removed their assignment May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
zetaclient Issues related to ZetaClient
Projects
None yet
2 participants