New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vectors: function zsl_vec_zte, missing (-) in if statement #46

Open

ruehlchris opened this issue Jan 25, 2023 · 0 comments · May be fixed by #51

ruehlchris commented Jan 25, 2023

zscilib/src/vectors.c

Line 375 in 0035be5

(v->data[g - x] <= 0.0 && v->data[g - x] > epsilon)) {

the logic check for the right hand side never match because it check for x <= 0.0 && x > epsilon.
correction x<=0.0 && x > (-) epsilon.

if ((v->data[g - x] >= 0.0 && v->data[g - x] < epsilon) || (v->data[g - x] <= 0.0 && v->data[g - x] > -epsilon)) {

The text was updated successfully, but these errors were encountered:

microbuilder linked a pull request

that will close this issue

Fixes some logical issues in matrix and vector code #51

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment