-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log: make name param explicit #9368
Conversation
Before we starting using the logging subsystem everywhere, wanted to see about this change (needs some updates to the docs if the change is agreeable). |
Codecov Report
@@ Coverage Diff @@
## master #9368 +/- ##
=======================================
Coverage 52.17% 52.17%
=======================================
Files 212 212
Lines 25892 25892
Branches 5561 5561
=======================================
Hits 13508 13508
Misses 10126 10126
Partials 2258 2258 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea and it looks good. Only documentation must be then update
cc: @pizi-nordic @jarz-nordic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for me. The only thing which might be potentially missing is the define/API for fetching current module name (similar to LOG_CURRENT_MODULE_ID()).
Rather than having some implied name for the logging name, explicitly pass it in the macros LOG_MODULE_REGISTER & LOG_MODULE_DECLARE. Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
I updated the docs, figure we can address the addition of some new API to fetch the name as a separate PR. Wanted to have this go in before all the other changes to convert a bunch of subsystems to use logging. |
I thought this was sufficient since it passed CI, but it breaks. Re-opened as PR #9450 |
Rather than having some implied name for the logging name, explicitly
pass it in the macros LOG_MODULE_REGISTER & LOG_MODULE_DECLARE.
Signed-off-by: Kumar Gala kumar.gala@linaro.org