-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move kernel/soc/arch/drivers to new logger #10029
Move kernel/soc/arch/drivers to new logger #10029
Conversation
@@ -221,7 +225,7 @@ void *_impl_k_object_alloc(enum k_objects otype) | |||
|
|||
dyn_obj = z_thread_malloc(sizeof(*dyn_obj) + obj_size_get(otype)); | |||
if (!dyn_obj) { | |||
SYS_LOG_WRN("could not allocate kernel object"); | |||
LOG_WRN("could not allocate kernel object"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This the only place we use logging in the kernel??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right now yes, I think we will have more once this is moved to the new logger.
obsoletes #9429 as well |
316277d
to
7fe8c5c
Compare
@nashif : isn't the new logger a bit immature still? |
no, afaik it is ready to go and we need to move everyone to the new logger in 1.14. |
7fe8c5c
to
e30aaed
Compare
|
||
#define LOG_LEVEL CONFIG_ARCH_LOG_LEVEL | ||
#include <logging/log.h> | ||
LOG_MODULE_DECLARE(mpu); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that even when #10045 is introduced this will not work. In arm_mpu.c (which includes this file) there will be 2 implementations of __log_current_const_data_get. We need to come up with a solution for logging in headers.
@nashif rather than duplicate my work (my pull-requests were clearly marked with the appropriate tag - see:
area: Logging
) you could have cherry-picked my patches. There was not much work left as I was waiting for the v1.13 release and the pull-requests You might actually have cherry-picked my patches but remove my credit (see #9429 (comment))... I did this boring work to help the Open Source project to have the logging subsystem to be merged into v1.13 as it was initially planned and also to not need my other pull-request that I think is needed in v1.13 without the new logging subsystem. |
Remove single use of logger in favor of printk. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Fix format type in log message. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Remove debug message using undefined functions. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Use a common log level for display drivers. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Use boolean kconfig for setting log level. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
log modules of kernel are creating noise, set them to off to have this test work as expected. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Move to new logger and update all related samples and configs. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Fix code style after moving to new logger. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Migrate from `SYS_LOG` to `LOG` logging mechanism. Signed-off-by: Olivier Martin <olivier.martin@proglove.de>
log message missing a parameter for the pin. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Rename log level variable: CONFIG_LOG_GPIO_LEVEL to CONFIG_GPIO_LOG_LEVEL Use template for log levels. Register modules in drivers using logging. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Migrate from `SYS_LOG` to `LOG` logging mechanism. Signed-off-by: Olivier Martin <olivier.martin@proglove.de>
Rename log level variable: CONFIG_LOG_IMG_MANAGER_LEVEL to CONFIG_IMG_MANAGER_LOG_LEVEL Use template for log levels. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Use new logger and remove usage of SYS_LOG. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Fix layout and syntax with uncrustify after changing to new logger. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Fix layout and syntax with uncrustify after changing to new logger. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Use CONFIG_LOG instead of old CONFIG_SYS_LOG. The drivers in questions already moved to new logger. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Remove include that is not being used in the file. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
ac49a89
to
6c2ac92
Compare
Still pending fix for #10026