Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly indicate ISR number in SystemView #33363

Closed
khutchens opened this issue Mar 16, 2021 · 1 comment
Closed

Properly indicate ISR number in SystemView #33363

khutchens opened this issue Mar 16, 2021 · 1 comment
Labels
area: Tracing Tracing Enhancement Changes/Updates/Additions to existing features

Comments

@khutchens
Copy link

Is your enhancement proposal related to a problem? Please describe.
When recording traces via SystemView, all ISRs share IRQ number 0, which makes ISR tracing pretty useless.

Describe the solution you'd like
SystemView should show the individual ISR as separate traces with the correct IRQ numbers.

This is a pretty easy change since the SystemView tracing backend already provides sysview_get_interrupt(), which propogates the current interrupt number (not currently set) back to SystemView. All that's needed is a hook in isr_wrapper.S:158 (and other configurations) to set the current IRQ number during ISR entry.

I'm happy to submit a PR to add this, but I'm not equipped to add or test it for anything other than the CONFIG_ARMV7_M_ARMV8_M_MAINLINE configuration, which would be a pretty incomplete addition.

@khutchens khutchens added the Enhancement Changes/Updates/Additions to existing features label Mar 16, 2021
@nashif
Copy link
Member

nashif commented May 28, 2021

This was already addressed in 10ee29e

@nashif nashif closed this as completed May 28, 2021
@nashif nashif added the area: Tracing Tracing label May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Tracing Tracing Enhancement Changes/Updates/Additions to existing features
Projects
None yet
Development

No branches or pull requests

2 participants