Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reimplement tests/kernel/timer/timer_api #32339

Closed
pabigot opened this issue Feb 15, 2021 · 1 comment
Closed

reimplement tests/kernel/timer/timer_api #32339

pabigot opened this issue Feb 15, 2021 · 1 comment
Labels
area: Tests Issues related to a particular existing or missing test area: Timer Timer Enhancement Changes/Updates/Additions to existing features

Comments

@pabigot
Copy link
Collaborator

pabigot commented Feb 15, 2021

As described in #32277 (comment) and related discussion, the timer_api test was designed for a world that exists only when tickless timer is disabled; that world was made opt-in via c0a184c back in 2018.

This repeatedly causes problems where the conditions for passing are tweaked as new platforms are discovered to reveal gaps in the test design.

The test should be re-implemented to be correct in the face of tickless configurations. To the degree CONFIG_TICKLESS_KERNEL=n is to be supported it should have an equivalent test.
@pabigot pabigot added the bug The issue is a bug, or the PR is fixing a bug label Feb 15, 2021
@pabigot pabigot self-assigned this Feb 15, 2021
@nashif nashif added Enhancement Changes/Updates/Additions to existing features area: Tests Issues related to a particular existing or missing test and removed bug The issue is a bug, or the PR is fixing a bug labels Feb 20, 2021
@pabigot pabigot removed their assignment Feb 22, 2021
@FRASTM FRASTM mentioned this issue Feb 23, 2021
Closed
@PerMac PerMac mentioned this issue Mar 3, 2021
Closed
@carlescufi carlescufi added the area: Timer Timer label Mar 3, 2021
@nashif
Copy link
Member

nashif commented Nov 17, 2022

new tests or improved tests are always welcome, just submit a PR.

@nashif nashif closed this as not planned Won't fix, can't repro, duplicate, stale Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: Tests Issues related to a particular existing or missing test area: Timer Timer Enhancement Changes/Updates/Additions to existing features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nashif @pabigot @carlescufi