Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config shell & bt shell same time cause fail #10166

Closed
lgl88911 opened this issue Sep 23, 2018 · 8 comments
Closed

config shell & bt shell same time cause fail #10166

lgl88911 opened this issue Sep 23, 2018 · 8 comments
Assignees
Labels
area: Shell Shell subsystem

Comments

@lgl88911
Copy link
Collaborator

lgl88911 commented Sep 23, 2018

Hi,pals:
I find eable the config same time, will fail:

CONFIG_SHELL=y

CONFIG_NET_SHELL=y
CONFIG_BT_SHELL=y
CONFIG_NET_L2_BT_SHELL=y

the log:

-- Generating zephyr/include/generated/generated_dts_board.h
-- Cache files will be written to: /home/frank/.cache/zephyr
CMake Error at /home/frank/work/project/zephyr/cmake/extensions.cmake:796 (add_subdirectory):
  The binary directory

    /home/frank/work/project/nrf52_moderate/apps/ipsptest/build/zephyr/subsys/shell

  is already used to build a source directory.  It cannot be used to build
  source directory

    /home/frank/work/project/zephyr/subsys/shell

  Specify a unique binary directory name.
Call Stack (most recent call first):
  /home/frank/work/project/zephyr/subsys/CMakeLists.txt:7 (add_subdirectory_ifdef)

if disable CONFIG_SHELL or other config will pass.
The means bt shell cmd and shell history function can't co-exist. This is a issue or sepc?Can support bt shell cmd using history function? Thanks !

@lgl88911 lgl88911 changed the title config shell & console shell same time cause fail config shell & bt shell same time cause fail Sep 23, 2018
@jakub-uC
Copy link
Contributor

jakub-uC commented Oct 9, 2018

I see that bt commands have been recently moved to the new shell. Do you still have an issue with BT shell?

@jakub-uC
Copy link
Contributor

I digged in a bit more.
New shell has different design compering to the old one. We are in the middle of transition so it may not still not work.
Current concept is that you can enable shell commands via Kconfig for NET, BT and so on. But shell instance itself needs to be created separately.

@lgl88911
Copy link
Collaborator Author

@jarz-nordic Yes, I tested look like you。 BT_SHELL is old shell style , but CONFIG_SHELL is new shell style. Is there a plan covert BT&Net shell to new shell style?

@jakub-uC
Copy link
Contributor

jakub-uC commented Oct 11, 2018

@lgl88911 : yes of course. I hope that in 2 weeks we will be able to do it.
Once PR: #10511 is merged it will be very easy task.

@lgl88911
Copy link
Collaborator Author

@jarz-nordic Thanks, I‘ll wait your news

@jakub-uC
Copy link
Contributor

@lgl88911 : Please track PR #9825. Once it will be merged you shall be able to use new shell.

@jakub-uC
Copy link
Contributor

@lgl88911 : Please check now if it is working as you expect it.

@lgl88911
Copy link
Collaborator Author

lgl88911 commented Oct 17, 2018

@jarz-nordic Update code & test OK, Thanks a lot!
config:

CONFIG_BT_SHELL=y
CONFIG_NET_L2_BT_SHELL=y
CONFIG_PRINTK=y
CONFIG_KERNEL_SHELL=y
CONFIG_NET_SHELL=y
CONFIG_SHELL=y
CONFIG_LOG_BACKEND_UART=n
CONFIG_LOG=y
CONFIG_SHELL_HISTORY=y

Board run shell:

uart:~$ 
  bt       clear    gatt     help     history  kernel   l2cap    log
  net      net_bt   resize   shell    ticker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Shell Shell subsystem
Projects
None yet
Development

No branches or pull requests

4 participants